aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2017-04-08libdraw: replace hand-rolled realloc, preventing buffer overflow.Ray Lai1-3/+1
The original buffer is f->nsubf*sizeof *subf bytes (oldsize) large. Once it's full, a new buffer of (f->nsubf+DSUBF)*sizeof *subf (newsize) is mallocated. Unfortunately memmove() reads (newsize) bytes from the original (oldsize) buffer, causing a buffer overflow. By switching to realloc(), we don't need to do buffer size calculation, memmoving, and freeing of the original buffer. Change-Id: Ibf85bc06abe1c8275b11acb1d7d346a14291d2cd Reviewed-on: https://plan9port-review.googlesource.com/1520 Reviewed-by: Gleydson Soares <gsoares@gmail.com>
2017-04-089term: Add missing parentheses, preventing buffer overflow.Ray Lai1-1/+1
(el-sr) is the string length and (sizeof wdir - strlen(name) - 20) is the buffer size. When the string length is greater than the buffer size, the beginning of the string is supposed to be trimmed to fit in the buffer size. Unfortunately a pair of parentheses were missing, pointing sr outside the buffer, and the for loop below then reads outside the buffer. For certain binary data printed in a window, it causes a segfault. Change-Id: Iffeaa348260ee2a5a36d9577308fb8d1c1688d05 Reviewed-on: https://plan9port-review.googlesource.com/1540 Reviewed-by: Gleydson Soares <gsoares@gmail.com>
2017-02-109pfuse: support osxfuse>=3.3.0James Porter1-7/+28
Change-Id: Ibca68261016b0f588e169e9f319748b5ba7d15ac Reviewed-on: https://plan9port-review.googlesource.com/2700 Reviewed-by: michaelian ennis <michaelian.ennis@gmail.com> Reviewed-by: Russ Cox <rsc@swtch.com>
2017-01-099term: c nitsRuss Cox2-2/+3
Change-Id: Ia18ebb28f24bc69f404004896f9ce54ddb53faf9 Reviewed-on: https://plan9port-review.googlesource.com/2782 Reviewed-by: Russ Cox <rsc@swtch.com>
2017-01-09cmd/9term: A hack because I'm constantly getting confused about ^C vs fn+deleteDave Presotto3-0/+11
Since Google (and a lot of the outside) is so engrained with using ^C as interrupt, I'd like to be able to use it in 9term if I've stty'd my intr to ^C. Without this, hitting ^C still works but if the program behind the window isn't reading from /dev/cons, it won't take effect till after I hit a newline which is often very confusing. I know this is a hack since it only works if I stty intr ^C but that seems the only other character that gets used anyways. Change-Id: I0597e63b2d7628f5668c648e6dba6f281e4b27fd Reviewed-on: https://plan9port-review.googlesource.com/2742 Reviewed-by: Russ Cox <rsc@swtch.com>
2017-01-07src/cmd: take fontsrv out of BUGGEREDDave Presotto1-1/+1
Change-Id: Iac5726f13039fba818536dc375d38cc3e27aca3a Reviewed-on: https://plan9port-review.googlesource.com/2741 Reviewed-by: Russ Cox <rsc@swtch.com>
2017-01-06all: fix or silence all INSTALL warnings on macOSRuss Cox15-87/+106
Should be a clean build now. Change-Id: Id3460371cb5e8d4071f8faa9c2aec870d213a067 Reviewed-on: https://plan9port-review.googlesource.com/2781 Reviewed-by: Russ Cox <rsc@swtch.com>
2017-01-069term, win: work around bsd linker nonsenseRuss Cox3-2/+9
Change-Id: Ifcef0636ee1e1fd0f9b06a8d1a99d58fae831318 Reviewed-on: https://plan9port-review.googlesource.com/2780 Reviewed-by: Russ Cox <rsc@swtch.com>
2017-01-069term, mc: conspire to handle hidpi displaysRuss Cox2-1/+26
9term now uses the low bit of ws.ws_ypixel to signal whether this is a hidpi display, and mc adjusts the font it uses for columnation accordingly. Makes 'lc' work right on hidpi displays. Change-Id: I52928871ffb7f4c6fd6722f3d59f1836379148c6 Reviewed-on: https://plan9port-review.googlesource.com/2760 Reviewed-by: Russ Cox <rsc@swtch.com>
2016-11-20include: define _DEFAULT_SOURCEDavid du Colombier6-0/+6
Since glibc 2.20, the _BSD_SOURCE and _SVID_SOURCE macros are deprecated in favor of the _DEFAULT_SOURCE macro. See https://sourceware.org/glibc/wiki/Release/2.20#Packaging_Changes Change-Id: I18dd6a698f3f5aa51d1e45bf53b031bb061e17e8 Reviewed-on: https://plan9port-review.googlesource.com/1500 Reviewed-by: David du Colombier <0intro@gmail.com>
2016-11-02libregexp: various fixesDavid du Colombier3-6/+4
- Check before dereference. - Fix memory leak - Remove duplicate if statement. - Remove trailing spaces. Change-Id: I140a05c8f7006493dddae753aebfa5b4577c65ef Reviewed-on: https://plan9port-review.googlesource.com/1301 Reviewed-by: Neven Sajko <nsajko@gmail.com> Reviewed-by: Russ Cox <rsc@swtch.com>
2016-11-02fix segfaults on OpenBSD: int cannot hold all the values a ptrdiff_t can take.Gleydson Soares1-1/+1
Change-Id: I90806e6f2e46a94f38aa0a8a7038aa6599b448b3 Reviewed-on: https://plan9port-review.googlesource.com/2660 Reviewed-by: Russ Cox <rsc@swtch.com>
2016-04-18font: s/10/11 in ascent for unicode.7x13.fontRob Pike1-1/+1
The subfont files were fixed in https://plan9port-review.googlesource.com/#/c/1351/ but the font file was not. Change-Id: I71ec13af9163f1b97b2fd499ff170a59c27ea7ec Reviewed-on: https://plan9port-review.googlesource.com/1490 Reviewed-by: Nigel Tao <nigeltao@golang.org> Reviewed-by: Russ Cox <rsc@google.com>
2016-01-22fontsrv: do not try to look up surrogate pairsRuss Cox1-0/+2
Change-Id: Ib0a680e123ba02b41e1029e356543c24e8b4647e Reviewed-on: https://plan9port-review.googlesource.com/1430 Reviewed-by: Russ Cox <rsc@swtch.com>
2015-12-08auxstats: fix OpenBSD by using getifaddrs(3) instead of kvm(3)Gleydson Soares2-75/+24
Change-Id: I6a096ba24809a402911c30406d384d16c03fc96c Reviewed-on: https://plan9port-review.googlesource.com/1410 Reviewed-by: Russ Cox <rsc@swtch.com>
2015-11-11devdraw: cocoa: set window title on main threadsqweek1-2/+12
Change-Id: Ie818f9246f749a9d3293019a1e01be4ce7e368b9 Reviewed-on: https://plan9port-review.googlesource.com/1400 Reviewed-by: Russ Cox <rsc@swtch.com>
2015-11-10win: local \r cancellationRuss Cox1-1/+14
Change-Id: I4becec052af58c5a52b777004867eb23023b9403 Reviewed-on: https://plan9port-review.googlesource.com/1391 Reviewed-by: Russ Cox <rsc@google.com>
2015-11-109term, win: better \r handling (thanks, git)Russ Cox2-1/+31
Change-Id: I75563b911b54d8957d2d004b9c27d0a2f8f043b3 Reviewed-on: https://plan9port-review.googlesource.com/1390 Reviewed-by: Russ Cox <rsc@google.com>
2015-11-10INSTALL: append /usr/X11R6/include and /usr/X11R6/include/freetype2 toGleydson Soares1-1/+2
X11 headers detection, so that enable fontsrv build on OpenBSD. Change-Id: I2f3f766339a9f8beed647dfbb19a588d1825732a Reviewed-on: https://plan9port-review.googlesource.com/1290 Reviewed-by: Russ Cox <rsc@google.com>
2015-08-27mk: avoid infinite loop when targets are repeatedRuss Cox2-0/+6
Fixes "mk -f /tmp/x.mk y x" or "mk -f /tmp/x.mk" where /tmp/x.mk is: x y x: f echo hi Change-Id: I7fa87dc4750c04fdba010b990c190722b432b333 Reviewed-on: https://plan9port-review.googlesource.com/1361 Reviewed-by: Russ Cox <rsc@swtch.com>
2015-08-27fontsrv: use 64 chars per subfont instead of 256Russ Cox4-9/+14
Makes loading faster, and makes larger sizes not too wide. Change-Id: I076c83fdb9577c1e596de45558f38ea93e3a2a31 Reviewed-on: https://plan9port-review.googlesource.com/1360 Reviewed-by: Russ Cox <rsc@swtch.com>
2015-08-26font/fixed: adjust the ascent for the 7x13 subfontsRob Pike25-0/+0
The ascent in these subfonts was 10 pixels but the images are using an 11 ascent, so fix all the ascents in the files. This is the global ascent, not for each character. This change makes them consistent with the usage in, for instance, the lucsans directory. Problem was found with some new Go code to handle these fonts, and we'd like to publish the updated files so the Go code can use them in a test. If preferable, of course, they could be put under some other name. Others may also want adjustment, but we can start here. Change-Id: I6c518604eed5b35db641dc537e4b5a2810ad1cf9 Reviewed-on: https://plan9port-review.googlesource.com/1351 Reviewed-by: Nigel Tao <nigeltao@golang.org> Reviewed-by: Russ Cox <rsc@swtch.com>
2015-08-26font/lucsans: fix reference to supsub.9Rob Pike1-1/+1
The euro files refer to the version in ../lucm/supsub.9 but unicode.9x24 was missing the ../lucm Change-Id: I1a3237a3ea5271426cc53243785229634a843146 Reviewed-on: https://plan9port-review.googlesource.com/1350 Reviewed-by: Russ Cox <rsc@swtch.com>
2015-06-29upas/nfs: search for stunnele3 in $PATHGleydson Soares1-4/+7
Do not hardcode stunnel directory path, just make sure that is installed in user '$PATH'. it is required for 'mailfs -t' TLS support, so printout an error string if it was not found. Tested with latest stunnel version 5.17 on OpenBSD and macosx. % mailfs -t imap.gmail.com ; echo $? 0 Change-Id: Icbd507c7efa81ef2aa7aed37bec5f639b37526cb Reviewed-on: https://plan9port-review.googlesource.com/1280 Reviewed-by: Russ Cox <rsc@swtch.com>
2015-06-03all: linux/arm64 portAram Hăvărneanu4-0/+17
Really trivial port. Change-Id: Ib2e3ad48df555ca4bd9339ddf79a832be895bd95 Reviewed-on: https://plan9port-review.googlesource.com/1030 Reviewed-by: Russ Cox <rsc@google.com>
2015-06-03libregexp: fix copy-paste errorDavid du Colombier1-1/+1
Change-Id: I042d63ea62e2abd599bf9767acb3374bb39ddc7d Reviewed-on: https://plan9port-review.googlesource.com/1050 Reviewed-by: Minux Ma <minux@golang.org> Reviewed-by: Russ Cox <rsc@google.com>
2015-06-03all: linux/mips portAram Hăvărneanu5-0/+18
Change-Id: I0af67bc44c7bb62a8e5a47eac597367f521f1c11 Reviewed-on: https://plan9port-review.googlesource.com/1210 Reviewed-by: Russ Cox <rsc@google.com>
2015-06-03all: fix openbsd buildAram Hăvărneanu2-3/+4
Change-Id: I6eaeebc9b6a4d78ce07efe7680ba8f2eff16462f Reviewed-on: https://plan9port-review.googlesource.com/1230 Reviewed-by: Minux Ma <minux@golang.org> Reviewed-by: Russ Cox <rsc@google.com>
2015-06-03keyboard.h: add some missing key enums from Plan 9mischief1-1/+6
Change-Id: I0d8b94037309b15f839588c6547acaaaf3e2ed4d Reviewed-on: https://plan9port-review.googlesource.com/1151 Reviewed-by: Russ Cox <rsc@google.com>
2015-06-03acme: add focus change to logSergiusz Urbaniak1-0/+6
Currently new, put and del events are being logged. This patch adds a focus event to the log whenever the user changes the focus to another window. This lets programs react to files being edited in acme without the need of being restarted. Change-Id: Idf35c0d7dbfca30e79724dc9f49e44c6a4eb6a1e Reviewed-on: https://plan9port-review.googlesource.com/1140 Reviewed-by: Russ Cox <rsc@google.com>
2015-06-03devdraw: plumb drag-n-dropped filesmarius a. eriksen3-10/+57
Change-Id: I7585870aee57c7482ebdd19c117be7982123ce79 Reviewed-on: https://plan9port-review.googlesource.com/1130 Reviewed-by: Russ Cox <rsc@google.com>
2015-05-15libdraw, acme: fix acme segfault triggered passing an invalid fontGleydson Soares1-0/+2
acme -f nosuchfont Change-Id: Iaa727db02b43e63082130796ec97c0efb7fe2b19 Reviewed-on: https://plan9port-review.googlesource.com/1220 Reviewed-by: Russ Cox <rsc@swtch.com>
2015-02-18fontsrv: fix x11 buildRuss Cox1-1/+0
Change-Id: I60eca10d7749ec71dc2ffbb0fbde564a1b711fa1 Reviewed-on: https://plan9port-review.googlesource.com/1180 Reviewed-by: Russ Cox <rsc@swtch.com>
2015-02-17man: document font syntaxesRuss Cox5-23/+130
Change-Id: Id441d4df192c47388af6b5da306f14d90f066d18 Reviewed-on: https://plan9port-review.googlesource.com/1173 Reviewed-by: Russ Cox <rsc@swtch.com>
2015-02-17devdraw: enable retina behavior by default on OS XRuss Cox1-3/+3
Change-Id: I243a1fe3f9ec0841570c4cd69c02be9cfd9ade50 Reviewed-on: https://plan9port-review.googlesource.com/1172 Reviewed-by: Russ Cox <rsc@swtch.com>
2015-02-17libdraw: refine hidpi font selectionRuss Cox4-1/+44
Change-Id: Id1e6a2630713024a1925ad1341bb9c846f82e93e Reviewed-on: https://plan9port-review.googlesource.com/1171 Reviewed-by: Russ Cox <rsc@swtch.com>
2015-02-17libdraw: autoscale fonts when moving between low and high dpi screensRuss Cox9-28/+243
Change-Id: I6093955b222db89dfe437fb723593b173d888d01 Reviewed-on: https://plan9port-review.googlesource.com/1170 Reviewed-by: Russ Cox <rsc@swtch.com>
2015-02-17libdraw: add 2*font syntax for scaled fontsRuss Cox7-5/+77
An experiment. Change-Id: I40660a211b8372701597d80f7e86917e94cccbaa Reviewed-on: https://plan9port-review.googlesource.com/1161 Reviewed-by: Russ Cox <rsc@swtch.com>
2015-02-17fontsrv: use CoreText API on OS XRuss Cox5-106/+143
This gets us font fallback for free and avoids use of a deprecated API that might go away some day. Change-Id: I4b9b1a1ce3e6d98bfb407e3baea13f4adfe2c26a Reviewed-on: https://plan9port-review.googlesource.com/1160 Reviewed-by: Russ Cox <rsc@swtch.com>
2014-12-02CONTRIBUTING.md: fix link to codereview(1)Russ Cox1-1/+1
Change-Id: I259a397398776bf9a172f1f4ed69e608166f35fb Reviewed-on: https://plan9port-review.googlesource.com/1097 Reviewed-by: Russ Cox <rsc@swtch.com>
2014-12-02fontsrv: disable X11 hintingEthan Burns1-1/+1
Discussion at: https://groups.google.com/d/topic/plan9port-dev/L7RVkXPmrdY/discussion https://github.com/9fans/plan9port/pull/7 Change-Id: I4f3a6791436120388ad8798e519f5e8473dd9306 Reviewed-on: https://plan9port-review.googlesource.com/1095
2014-12-029pfuse: Disable glibc workaround for O_LARGEFILE on ARMMerlijn Wajer1-1/+4
9pfuse fails on ARM when O_LARGEFILE is supported. glibc does define O_LARGEFILE properly on ARM, and the value is different than what that this workaround suggests, causing it to wrongly detect bad flags. Change-Id: I02b0cc222ca7785c4b1739c3df3caa17cf7bc265 Reviewed-on: https://plan9port-review.googlesource.com/1094 Reviewed-by: Russ Cox <rsc@swtch.com>
2014-12-02install.txt: regenerate (9 man 1 intro >install.txt)Russ Cox1-82/+203
Change-Id: I80331732ce955d5b025a3552d15c6d7494752bf6 Reviewed-on: https://plan9port-review.googlesource.com/1093 Reviewed-by: Russ Cox <rsc@swtch.com>
2014-12-02libdraw, libframe, acme: fix, guard against inverted range in textsetselectRuss Cox3-3/+15
Credit to Roi Martin <jroi.martin@gmail.com> for noticing that libdraw was being passed a negative string length and for finding the sequence of keystrokes that make acme do it reproducibly. Change-Id: If3f3d04a25c506175f740d3e887d5d83b5cd1bfe Reviewed-on: https://plan9port-review.googlesource.com/1092 Reviewed-by: Russ Cox <rsc@swtch.com>
2014-12-02devdraw: fix title and "open in top" on OS XRoi Martin1-1/+4
On OSX 10.10, when you open an application that depends on devdraw, the title bar only shows the first letter of the application's name. The patch sets a default title as soon as the window is created, which fixes this issue. On OSX 10.10, when you open an application that depends on devdraw, this application is opened in top of other windows, however the menu bar is not updated. The patch calls topwin() at the end of makewin() in src/cmd/devdraw/cocoa-screen.m . Change-Id: Ie036928b5574c8df20ad8b2b54047e2f7a22bb41 Reviewed-on: https://plan9port-review.googlesource.com/1091 Reviewed-by: Russ Cox <rsc@swtch.com>
2014-12-02CONTRIBUTING.md: add message about pull requestsRuss Cox1-0/+7
Change-Id: Id3f1f8e16bbbaa99ead6d227c0b3dade9727ec61 Reviewed-on: https://plan9port-review.googlesource.com/1090 Reviewed-by: Russ Cox <rsc@swtch.com>
2014-11-17codereview: use 'git branch -v' for pendingRuss Cox1-1/+1
Change-Id: Ib80b19cf69a15860315b2d7a38baf3b05d693acc
2014-11-17cmd: rename *.C to *.cRuss Cox4-0/+0
These were *.C back in 2003, before the 9 script, to avoid conflicts with the system utilities. A later change renamed them, but that change seems to have been lost during the hg->git conversion because I ran the conversion on a case-insensitive file system. Change-Id: Id32c99cb9571ef0e185c3cc9e8c8d6d5b48ca195
2014-11-16man: more Mercurial references changed to GitRuss Cox3-5/+5
Change-Id: I940a21d67b21b5dd139cb20b9fae9595506fc5ae
2014-11-16codereview: make commit -a the default; warn about uncommitted changes at uploadRuss Cox3-25/+38
also update README.md for github Change-Id: I7d578a902ffed7f6d69780721e29a1972b6f6992
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-06 19:42:06 +0000