Age | Commit message (Collapse) | Author | Files | Lines |
|
Change-Id: Ib80b19cf69a15860315b2d7a38baf3b05d693acc
|
|
These were *.C back in 2003, before the 9 script, to avoid conflicts
with the system utilities. A later change renamed them, but that
change seems to have been lost during the hg->git conversion
because I ran the conversion on a case-insensitive file system.
Change-Id: Id32c99cb9571ef0e185c3cc9e8c8d6d5b48ca195
|
|
Change-Id: I940a21d67b21b5dd139cb20b9fae9595506fc5ae
|
|
also update README.md for github
Change-Id: I7d578a902ffed7f6d69780721e29a1972b6f6992
|
|
Change-Id: I2e644aa2d693692f33d017c00367a734039532f1
|
|
Change-Id: Ifd9fda05e15c9e1e106ffd4e30e1dafe8423cdf4
|
|
- rewrite .gitignore to use git patterns
- mv hg(1) to git(1) and rewrite
- add lib/git/commit-msg.hook
- add skeleton codereview script
- update codereview(1)
Change-Id: I061cd8e4de77ebbd6037a7c5d1582cd1d986f62f
|
|
Change-Id: I3ed51b54252307f387f71955bbf547928bf26b5b
|
|
|
|
|
|
Thanks to Akshat Kumar for reporting this issue.
LGTM=seed, rsc
R=rsc, seed
https://codereview.appspot.com/173770043
|
|
fixed warnings:
src/cmd/fossil/disk.c:37:14: warning: use of GNU 'missing =' extension in designator [-Wgnu-designator]
src/cmd/fossil/disk.c:38:14: warning: use of GNU 'missing =' extension in designator [-Wgnu-designator]
src/cmd/fossil/disk.c:39:14: warning: use of GNU 'missing =' extension in designator [-Wgnu-designator]
src/cmd/fossil/disk.c:40:13: warning: use of GNU 'missing =' extension in designator [-Wgnu-designator]
src/cmd/fossil/disk.c:41:14: warning: use of GNU 'missing =' extension in designator [-Wgnu-designator]
src/libndb/ndbreorder.c:41:55: warning: for loop has empty body [-Wempty-body]
ignored warnings:
src/cmd/acid/dbg.y:393:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
src/cmd/bc.y:1327:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
src/cmd/bc.y:1327:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
src/cmd/grep/grep.y:420:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
src/cmd/grep/grep.y:420:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
src/cmd/hoc/hoc.y:692:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
src/cmd/hoc/hoc.y:692:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
src/cmd/lex/parser.y:886:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
src/cmd/rc/syn.y:303:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
src/cmd/units.y:1003:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
src/libregexp/regcomp.c:19:16: warning: variable 'reprog' is not needed and will not be emitted [-Wunneeded-internal-declaration]
LGTM=rsc
R=rsc
https://codereview.appspot.com/158250043
|
|
Found by nwf.
TBR=rsc
https://codereview.appspot.com/162860045
|
|
TBR=rsc
https://codereview.appspot.com/158240043
|
|
LGTM=rsc
R=rsc
https://codereview.appspot.com/136520044
|
|
On NetBSD 5.0 and upper, mount() require
data_len as a fifth argument.
LGTM=rsc
R=rsc
CC=elbingmiss
https://codereview.appspot.com/111600043
|
|
LGTM=rsc
R=rsc
CC=plan9port-dev
https://codereview.appspot.com/119500043
|
|
LGTM=rsc
R=rsc
CC=plan9port-dev
https://codereview.appspot.com/115100043
|
|
TBR=rsc
https://codereview.appspot.com/112890043
|
|
R=rsc
https://codereview.appspot.com/92650043
|
|
TBR=rsc
https://codereview.appspot.com/107760043
|
|
They'll be copied back during installation
but then hg doesn't have to create those files
on systems that have trouble with them.
TBR=rsc
https://codereview.appspot.com/105800043
|
|
Acme tracks the most recent typing insertion point and
the home and end keys stop there on their way
up to the top or down to the bottom of the file.
That point should be iq1, and it should be adjusted
properly so that it's always between 0 and t->file->b.nc inclusive.
(This is all code from an external contributor, years old at this
point but new since Plan 9.)
Somehow, sometimes iq1 ends up a little beyond b.nc,
and when passed to textbacknl it crashes acme in bufread.
I can't see how that can happen but if it does, avoid the crash.
It's tempting to pull the insertion point code out entirely
but this is a little less invasive and should fix things for now.
TBR=rsc
https://codereview.appspot.com/107730043
|
|
We ran for a long time with 10ms kernel resolution,
so 10ms user space resolution here should be fine.
Some systems actually provide 1ms sleeps, which
makes this polling use a bit more cpu than we'd like.
Since the timers are for user-visible things, 10ms should
still be far from noticeable.
Reduces acme's cpu usage on Macs when plumber is missing
(and plumbproc is sleeping waiting for it to appear).
LGTM=aram, r
R=r, aram
https://codereview.appspot.com/99570043
|
|
This breaks ^C in win windows, as expected.
People use ^C, win expects and handles ^C,
so I don't think we can just take it away.
I've noticed that it is broken but assumed my ssh
was screwed up.
If you want to make WindowsKey+C,X,V do the
operations, by analogy with command+C,X,V
on Mac, that's fine with me.
««« original CL description
acme: copy/cut/paste with ctl+c,x,v
LGTM=rsc
R=rsc
CC=plan9port.codebot
https://codereview.appspot.com/69070045
»»»
TBR=rsc
CC=burns.ethan, r
https://codereview.appspot.com/96410045
|
|
smtp.c:232: warning: comparison with string literal results in unspecified behavior
smtp.c:244: warning: comparison with string literal results in unspecified behavior
marshal.c:1179: warning: variable ‘err’ set but not used
LGTM=rsc
R=rsc
https://codereview.appspot.com/93290043
|
|
LGTM=rsc
R=rsc
https://codereview.appspot.com/97370043
|
|
TBR=rsc
https://codereview.appspot.com/95010048
|
|
Reading /mnt/acme/log reports a log of window create,
put, and delete events, as they happen. It blocks until the
next event is available.
Example log output:
8 new /Users/rsc/foo.go
8 put /Users/rsc/foo.go
8 del /Users/rsc/foo.go
This lets acme-aware programs react to file writes, for example
compiling code, running a test, or updating an import block.
TBR=r
R=r
https://codereview.appspot.com/89560044
|
|
TBR=r
https://codereview.appspot.com/89510044
|
|
Bakul Shah has observed corrupted files being written
when acme writes over osxfuse to sshfs to a remote file system.
In one example we examined, acme is writing an 0xf03-byte
file in two system calls, first an 0x806-byte write and then a 0x6fd-byte
write. (0x806 is BUFSIZE/sizeof(Rune); this file has no multibyte UTF-8.)
What actually ends up happening is that an 0x806-byte file is written:
0x000-0x6fd contains what should be 0x806-0xf03
0x6fd-0x7fa contains zeros
0x7fa-0x806 contains what should be 0x7fa-0x806 (correct!)
The theory is that fuse or sshfs or perhaps the remote file server is
mishandling the unaligned writes. acme does not seem to be at fault.
Using bio here will make the writes align to 8K boundaries,
avoiding the bugs in whatever underlying piece is broken.
TBR=r
https://codereview.appspot.com/89550043
|
|
TBR=r
https://codereview.appspot.com/89390043
|
|
LGTM=rsc
R=rsc
https://codereview.appspot.com/72340043
|
|
LGTM=rsc
R=rsc
https://codereview.appspot.com/71070050
|
|
LGTM=rsc
R=rsc
CC=plan9port.codebot
https://codereview.appspot.com/69070045
|
|
TBR=rsc
https://codereview.appspot.com/74060043
|
|
And uses gcc for i386 and x86_64.
LGTM=rsc
R=rsc
https://codereview.appspot.com/69860044
|
|
LGTM=rsc
R=rsc
https://codereview.appspot.com/33240044
|
|
LGTM=rsc
R=rsc
https://codereview.appspot.com/31130043
|
|
Fix compilation problems, libdraw still doesn't work right yet.
LGTM=rsc
R=rsc
https://codereview.appspot.com/67820046
|
|
LGTM=rsc
R=rsc
https://codereview.appspot.com/67820044
|
|
LGTM=rsc
R=rsc
CC=plan9port.codebot
https://codereview.appspot.com/40780044
|
|
TBR=rsc
https://codereview.appspot.com/53820044
|
|
TBR=rsc
https://codereview.appspot.com/55700043
|
|
R=rsc
CC=plan9port.codebot
https://codereview.appspot.com/43990046
|
|
R=rsc
https://codereview.appspot.com/15100044
|
|
- the cursor is on the last line
- the navigation would put the cursor over the tag of the following text
R=rsc
CC=smckean83
https://codereview.appspot.com/15280045
|
|
R=rsc
https://codereview.appspot.com/13982043
|
|
R=rsc
https://codereview.appspot.com/13988043
|
|
R=rsc
https://codereview.appspot.com/13984043
|