aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2014-04-19acme: use buffered i/o to write fileRuss Cox1-1/+16
Bakul Shah has observed corrupted files being written when acme writes over osxfuse to sshfs to a remote file system. In one example we examined, acme is writing an 0xf03-byte file in two system calls, first an 0x806-byte write and then a 0x6fd-byte write. (0x806 is BUFSIZE/sizeof(Rune); this file has no multibyte UTF-8.) What actually ends up happening is that an 0x806-byte file is written: 0x000-0x6fd contains what should be 0x806-0xf03 0x6fd-0x7fa contains zeros 0x7fa-0x806 contains what should be 0x7fa-0x806 (correct!) The theory is that fuse or sshfs or perhaps the remote file server is mishandling the unaligned writes. acme does not seem to be at fault. Using bio here will make the writes align to 8K boundaries, avoiding the bugs in whatever underlying piece is broken. TBR=r https://codereview.appspot.com/89550043
2014-04-18acme: fix Get of dir in nameless window (thanks Colton Lewis)Russ Cox1-1/+1
TBR=r https://codereview.appspot.com/89390043
2014-03-25dist/main.html: update supported systems and commit log link.Shenghou Ma1-3/+4
LGTM=rsc R=rsc https://codereview.appspot.com/72340043
2014-03-14man/man1/0intro.1: update supported systems.Shenghou Ma1-5/+7
LGTM=rsc R=rsc https://codereview.appspot.com/71070050
2014-03-13acme: copy/cut/paste with ctl+c,x,vEthan Burns2-0/+5
LGTM=rsc R=rsc CC=plan9port.codebot https://codereview.appspot.com/69070045
2014-03-13acme, sam: handle >1GB files correctlyRuss Cox4-4/+10
TBR=rsc https://codereview.appspot.com/74060043
2014-03-05INSTALL: fix architecture detection on Solaris.Shenghou Ma1-0/+21
And uses gcc for i386 and x86_64. LGTM=rsc R=rsc https://codereview.appspot.com/69860044
2014-03-03fix gcc 4.8 warningsDavid du Colombier6-15/+5
LGTM=rsc R=rsc https://codereview.appspot.com/33240044
2014-03-03fossil: fix p9p changes on viewDavid du Colombier1-26/+28
LGTM=rsc R=rsc https://codereview.appspot.com/31130043
2014-02-27all: DragonFly port.Shenghou Ma14-15/+356
Fix compilation problems, libdraw still doesn't work right yet. LGTM=rsc R=rsc https://codereview.appspot.com/67820046
2014-02-24codereview: sync from Go.Shenghou Ma1-112/+185
LGTM=rsc R=rsc https://codereview.appspot.com/67820044
2014-01-22mac/Plumb: add URL scheme to Info.plistRob Kroeger1-1/+14
LGTM=rsc R=rsc CC=plan9port.codebot https://codereview.appspot.com/40780044
2014-01-22devdraw: clear altdown on focus out (thanks Ethan Burns)Russ Cox1-0/+1
TBR=rsc https://codereview.appspot.com/53820044
2014-01-22INSTALL: diagnose missing gcc on DarwinRuss Cox1-1/+5
TBR=rsc https://codereview.appspot.com/55700043
2014-01-06keyboard: add more sequences, from existing ones or RFC 1345Jonathan Cast2-0/+14
R=rsc CC=plan9port.codebot https://codereview.appspot.com/43990046
2013-10-23fossil: fix remaining warningsDavid du Colombier5-13/+13
R=rsc https://codereview.appspot.com/15100044
2013-10-22acme: scroll a directory window when navigating if:Rob Pike3-4/+29
- the cursor is on the last line - the navigation would put the cursor over the tag of the following text R=rsc CC=smckean83 https://codereview.appspot.com/15280045
2013-09-26xd: fix build by declaring swizz8David du Colombier1-1/+1
R=rsc https://codereview.appspot.com/13982043
2013-09-26fossil: cleanup mkfileDavid du Colombier1-62/+1
R=rsc https://codereview.appspot.com/13988043
2013-09-26fossil: create directoryDavid du Colombier1-0/+0
R=rsc https://codereview.appspot.com/13984043
2013-09-26fossil: import conf.rcDavid du Colombier1-0/+68
R=rsc https://codereview.appspot.com/13983043
2013-09-26fossil: cast Qid.vers, Dir.mode and Qid.mtime to u32int (thanks Tim Kack)David du Colombier1-4/+4
R=rsc https://codereview.appspot.com/13981043
2013-09-26fossil: fix various warningsDavid du Colombier5-95/+0
R=rsc https://codereview.appspot.com/13980043
2013-09-26fossil: required p9p changesDavid du Colombier15-67/+156
R=rsc https://codereview.appspot.com/13352057
2013-09-23fossil: move from liboventi to libthread and libventiDavid du Colombier38-1424/+1360
R=rsc https://codereview.appspot.com/13504049
2013-09-23fossil: import from plan 9David du Colombier50-0/+22325
R=rsc https://codereview.appspot.com/7988047
2013-09-06acme: execute commands with / using shellMarius Eriksen1-1/+1
This allows commands in bin subdirectories. R=rsc CC=plan9port.codebot https://codereview.appspot.com/13254044
2013-09-06acme Mail: add Search commandAkshat Kumar2-1/+63
Introduces the Search command for mailboxes. Arguments passed are treated as one space- separated string, passed on to mailfs' IMAP search interface. R=rsc, david.ducolombier CC=plan9port.codebot https://codereview.appspot.com/13238044
2013-09-06mailfs: allow spaces in box nameAkshat Kumar1-1/+16
Mail services (such as Google Mail) will often have directories with names that contain spaces. Acme does not support spaces in window names. So, replace spaces in mail directory names with the Unicode character for visible space. The code is a bit of an over-approximation and generally non-optimal. R=rsc, david.ducolombier, 0intro CC=plan9port.codebot https://codereview.appspot.com/13010048
2013-09-06mailfs: support for UTF-8 searchesAkshat Kumar1-10/+45
UTF-8 searches with the SEARCH command must be conducted in two steps: the first sends the SEARCH command with the length of the UTF-8 encoded string and the second sends the literal search term. The searches need to not be quoted. R=rsc, david.ducolombier, rsc, 0intro CC=plan9port.codebot https://codereview.appspot.com/13244043
2013-08-13rcmain: use new $termprog variableSteve McCoy2-1/+2
R=rsc CC=plan9port.codebot https://codereview.appspot.com/12505045
2013-08-06devdraw: set window name to argv[0]Russ Cox1-0/+120
R=rsc CC=r https://codereview.appspot.com/12577043
2013-08-069term: set TERM=dumb instead of TERM=9termRuss Cox4-1/+13
Everyone seems to assume that TERM != dumb implies ANSI escape codes are okay. In fact, many people assume that unconditionally, but it is easier to argue back about TERM=dumb than TERM=9term. This applies to acme win too, because they share the code. Set termprog=9term or termprog=win for clients who need to know. R=rsc CC=r https://codereview.appspot.com/12532043
2013-07-31acme: allow :6 in 5-line fileRuss Cox1-0/+2
R=rsc https://codereview.appspot.com/12162043
2013-07-17cmd/devdraw: clear keyboard state on lost focus.Roger Peppe2-0/+7
See https://bitbucket.org/rsc/plan9port/issue/128/alt-button-sticks-in-acme-sometimes-after R=rsc https://codereview.appspot.com/11453043
2013-07-02libregexp: update from Plan 9David du Colombier5-24/+25
R=rsc https://codereview.appspot.com/10690044
2013-06-21devdraw: fix x11 inputRuss Cox1-1/+1
R=rsc https://codereview.appspot.com/10458043
2013-03-19rc: avoid undefined CXi Wang1-4/+4
There are two bugs in pdec() on INT_MIN: * wrong output. `n = 1-n' should be `n = -1-n' when n is INT_MIN. * infinite loop. gcc optimizes `if(n>=0)' into `if(true)' because `-INT_MIN' (signed integer overflow) is undefined behavior in C, and gcc assumes the negation of a negative number must be positive. The resulting binary keeps printing '-' forever given INT_MIN. Try the simplified pdec.c below. $ gcc pdec.c $ ./a.out -2147483648 --214748364* $ gcc pdec.c -O2 $ ./a.out -2147483648 <infinite loop> $ gcc pdec.c -O2 -D__PATCH__ $ ./a.out -2147483648 -2147483648 === pdec.c === #include <stdio.h> #include <stdlib.h> #include <limits.h> #define io void void pchr(io *f, int c) { putchar(c); } void pdec(io *f, int n) { if(n<0){ #ifndef __PATCH__ n=-n; if(n>=0){ pchr(f, '-'); pdec(f, n); return; } /* n is two's complement minimum integer */ n = 1-n; #else if(n!=INT_MIN){ pchr(f, '-'); pdec(f, -n); return; } /* n is two's complement minimum integer */ n = -(INT_MIN+1); #endif pchr(f, '-'); pdec(f, n/10); pchr(f, n%10+'1'); return; } if(n>9) pdec(f, n/10); pchr(f, n%10+'0'); } int main(int argc, char **argv) { int n = atoi(argv[1]); pdec(NULL, n); putchar('\n'); } R=rsc CC=plan9port.codebot https://codereview.appspot.com/7241055
2013-03-19libsec: avoid undefined CXi Wang1-2/+1
gcc compiles `p + length < p' into 'length < 0' since pointer overflow is undefined behavior in C. This breaks the check against a large `length'. Use `length > pend - p' instead. There's no need to check `length < 0' since `length' is from length_decode() and should be non-negative. === Try the simplified code. void bar(void); void foo(unsigned char *p, int length) { if (p + length < p) bar(); } $ gcc -S -o - t.c -O2 ... foo: .LFB0: .cfi_startproc testl %esi, %esi js .L4 rep ret .L4: jmp bar .cfi_endproc Clearly `p' is not used at all. R=rsc CC=plan9port.codebot https://codereview.appspot.com/7231069
2013-03-11xd: accept -S for 8-byte swapRuss Cox2-0/+39
R=rsc https://codereview.appspot.com/7565045
2013-03-07devdraw: control+click = button 2, alt/shift+click = button 3Russ Cox3-26/+111
For single-button mouse users. R=rsc https://codereview.appspot.com/7620043
2013-02-08devdraw: silence unused variable warningsRuss Cox1-2/+6
R=rsc https://codereview.appspot.com/7304064
2013-02-08devdraw: disable XCopyArea optimizationRuss Cox1-2/+5
Ubuntu Precise seems to have a buggy X server that sometimes fails at XCopyArea. Let devdraw do it itself. This will slow down remote X a little bit, but slow and correct is better than fast and broken. R=rsc https://codereview.appspot.com/7310069
2013-01-30fontsrv: fix on X11 when X11H is not definedAlessandro Arzilli1-1/+1
R=rsc CC=plan9port.codebot https://codereview.appspot.com/7228044
2013-01-30libmach: fix crash in dwarfpc (misuse of realloc)Xi Wang1-0/+1
R=rsc CC=plan9port.codebot https://codereview.appspot.com/7225059
2013-01-30fontserv: fix build on FreeBSD 9.1Martin Neubauer1-1/+6
R=rsc https://codereview.appspot.com/7095050
2013-01-30CONTRIBUTORS: three moreRuss Cox1-1/+3
R=rsc https://codereview.appspot.com/7225073
2013-01-19jpegdump: fix build and warningsDavid du Colombier1-7/+8
R=rsc https://codereview.appspot.com/7070070
2013-01-04freq: fix crash with utf > 0xffff (thanks Andrey Mirtchovski)David du Colombier1-2/+2
R=rsc https://codereview.appspot.com/7029054
2013-01-03venti/wrarena: fix arenapart breakageDavid du Colombier1-3/+4
R=rsc https://codereview.appspot.com/7027044
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-12 20:05:02 +0000