Age | Commit message (Collapse) | Author | Files | Lines |
|
- Check before dereference.
- Fix memory leak
- Remove duplicate if statement.
- Remove trailing spaces.
Change-Id: I140a05c8f7006493dddae753aebfa5b4577c65ef
Reviewed-on: https://plan9port-review.googlesource.com/1301
Reviewed-by: Neven Sajko <nsajko@gmail.com>
Reviewed-by: Russ Cox <rsc@swtch.com>
|
|
Change-Id: I90806e6f2e46a94f38aa0a8a7038aa6599b448b3
Reviewed-on: https://plan9port-review.googlesource.com/2660
Reviewed-by: Russ Cox <rsc@swtch.com>
|
|
The subfont files were fixed in https://plan9port-review.googlesource.com/#/c/1351/
but the font file was not.
Change-Id: I71ec13af9163f1b97b2fd499ff170a59c27ea7ec
Reviewed-on: https://plan9port-review.googlesource.com/1490
Reviewed-by: Nigel Tao <nigeltao@golang.org>
Reviewed-by: Russ Cox <rsc@google.com>
|
|
Change-Id: Ib0a680e123ba02b41e1029e356543c24e8b4647e
Reviewed-on: https://plan9port-review.googlesource.com/1430
Reviewed-by: Russ Cox <rsc@swtch.com>
|
|
Change-Id: I6a096ba24809a402911c30406d384d16c03fc96c
Reviewed-on: https://plan9port-review.googlesource.com/1410
Reviewed-by: Russ Cox <rsc@swtch.com>
|
|
Change-Id: Ie818f9246f749a9d3293019a1e01be4ce7e368b9
Reviewed-on: https://plan9port-review.googlesource.com/1400
Reviewed-by: Russ Cox <rsc@swtch.com>
|
|
Change-Id: I4becec052af58c5a52b777004867eb23023b9403
Reviewed-on: https://plan9port-review.googlesource.com/1391
Reviewed-by: Russ Cox <rsc@google.com>
|
|
Change-Id: I75563b911b54d8957d2d004b9c27d0a2f8f043b3
Reviewed-on: https://plan9port-review.googlesource.com/1390
Reviewed-by: Russ Cox <rsc@google.com>
|
|
X11 headers detection, so that enable fontsrv build on OpenBSD.
Change-Id: I2f3f766339a9f8beed647dfbb19a588d1825732a
Reviewed-on: https://plan9port-review.googlesource.com/1290
Reviewed-by: Russ Cox <rsc@google.com>
|
|
Fixes "mk -f /tmp/x.mk y x" or "mk -f /tmp/x.mk" where /tmp/x.mk is:
x y x: f
echo hi
Change-Id: I7fa87dc4750c04fdba010b990c190722b432b333
Reviewed-on: https://plan9port-review.googlesource.com/1361
Reviewed-by: Russ Cox <rsc@swtch.com>
|
|
Makes loading faster, and makes larger sizes not too wide.
Change-Id: I076c83fdb9577c1e596de45558f38ea93e3a2a31
Reviewed-on: https://plan9port-review.googlesource.com/1360
Reviewed-by: Russ Cox <rsc@swtch.com>
|
|
The ascent in these subfonts was 10 pixels but the images
are using an 11 ascent, so fix all the ascents in the files.
This is the global ascent, not for each character. This change
makes them consistent with the usage in, for instance,
the lucsans directory.
Problem was found with some new Go code to handle these
fonts, and we'd like to publish the updated files so the Go
code can use them in a test. If preferable, of course, they could
be put under some other name.
Others may also want adjustment, but we can start here.
Change-Id: I6c518604eed5b35db641dc537e4b5a2810ad1cf9
Reviewed-on: https://plan9port-review.googlesource.com/1351
Reviewed-by: Nigel Tao <nigeltao@golang.org>
Reviewed-by: Russ Cox <rsc@swtch.com>
|
|
The euro files refer to the version in ../lucm/supsub.9 but unicode.9x24
was missing the ../lucm
Change-Id: I1a3237a3ea5271426cc53243785229634a843146
Reviewed-on: https://plan9port-review.googlesource.com/1350
Reviewed-by: Russ Cox <rsc@swtch.com>
|
|
Do not hardcode stunnel directory path, just make sure that is installed
in user '$PATH'. it is required for 'mailfs -t' TLS support, so printout
an error string if it was not found.
Tested with latest stunnel version 5.17 on OpenBSD and macosx.
% mailfs -t imap.gmail.com ; echo $?
0
Change-Id: Icbd507c7efa81ef2aa7aed37bec5f639b37526cb
Reviewed-on: https://plan9port-review.googlesource.com/1280
Reviewed-by: Russ Cox <rsc@swtch.com>
|
|
Really trivial port.
Change-Id: Ib2e3ad48df555ca4bd9339ddf79a832be895bd95
Reviewed-on: https://plan9port-review.googlesource.com/1030
Reviewed-by: Russ Cox <rsc@google.com>
|
|
Change-Id: I042d63ea62e2abd599bf9767acb3374bb39ddc7d
Reviewed-on: https://plan9port-review.googlesource.com/1050
Reviewed-by: Minux Ma <minux@golang.org>
Reviewed-by: Russ Cox <rsc@google.com>
|
|
Change-Id: I0af67bc44c7bb62a8e5a47eac597367f521f1c11
Reviewed-on: https://plan9port-review.googlesource.com/1210
Reviewed-by: Russ Cox <rsc@google.com>
|
|
Change-Id: I6eaeebc9b6a4d78ce07efe7680ba8f2eff16462f
Reviewed-on: https://plan9port-review.googlesource.com/1230
Reviewed-by: Minux Ma <minux@golang.org>
Reviewed-by: Russ Cox <rsc@google.com>
|
|
Change-Id: I0d8b94037309b15f839588c6547acaaaf3e2ed4d
Reviewed-on: https://plan9port-review.googlesource.com/1151
Reviewed-by: Russ Cox <rsc@google.com>
|
|
Currently new, put and del events are being logged.
This patch adds a focus event to the log
whenever the user changes the focus to another window.
This lets programs react to files being edited in acme
without the need of being restarted.
Change-Id: Idf35c0d7dbfca30e79724dc9f49e44c6a4eb6a1e
Reviewed-on: https://plan9port-review.googlesource.com/1140
Reviewed-by: Russ Cox <rsc@google.com>
|
|
Change-Id: I7585870aee57c7482ebdd19c117be7982123ce79
Reviewed-on: https://plan9port-review.googlesource.com/1130
Reviewed-by: Russ Cox <rsc@google.com>
|
|
acme -f nosuchfont
Change-Id: Iaa727db02b43e63082130796ec97c0efb7fe2b19
Reviewed-on: https://plan9port-review.googlesource.com/1220
Reviewed-by: Russ Cox <rsc@swtch.com>
|
|
Change-Id: I60eca10d7749ec71dc2ffbb0fbde564a1b711fa1
Reviewed-on: https://plan9port-review.googlesource.com/1180
Reviewed-by: Russ Cox <rsc@swtch.com>
|
|
Change-Id: Id441d4df192c47388af6b5da306f14d90f066d18
Reviewed-on: https://plan9port-review.googlesource.com/1173
Reviewed-by: Russ Cox <rsc@swtch.com>
|
|
Change-Id: I243a1fe3f9ec0841570c4cd69c02be9cfd9ade50
Reviewed-on: https://plan9port-review.googlesource.com/1172
Reviewed-by: Russ Cox <rsc@swtch.com>
|
|
Change-Id: Id1e6a2630713024a1925ad1341bb9c846f82e93e
Reviewed-on: https://plan9port-review.googlesource.com/1171
Reviewed-by: Russ Cox <rsc@swtch.com>
|
|
Change-Id: I6093955b222db89dfe437fb723593b173d888d01
Reviewed-on: https://plan9port-review.googlesource.com/1170
Reviewed-by: Russ Cox <rsc@swtch.com>
|
|
An experiment.
Change-Id: I40660a211b8372701597d80f7e86917e94cccbaa
Reviewed-on: https://plan9port-review.googlesource.com/1161
Reviewed-by: Russ Cox <rsc@swtch.com>
|
|
This gets us font fallback for free and avoids use of a
deprecated API that might go away some day.
Change-Id: I4b9b1a1ce3e6d98bfb407e3baea13f4adfe2c26a
Reviewed-on: https://plan9port-review.googlesource.com/1160
Reviewed-by: Russ Cox <rsc@swtch.com>
|
|
Change-Id: I259a397398776bf9a172f1f4ed69e608166f35fb
Reviewed-on: https://plan9port-review.googlesource.com/1097
Reviewed-by: Russ Cox <rsc@swtch.com>
|
|
Discussion at:
https://groups.google.com/d/topic/plan9port-dev/L7RVkXPmrdY/discussion
https://github.com/9fans/plan9port/pull/7
Change-Id: I4f3a6791436120388ad8798e519f5e8473dd9306
Reviewed-on: https://plan9port-review.googlesource.com/1095
|
|
9pfuse fails on ARM when O_LARGEFILE is supported.
glibc does define O_LARGEFILE properly on ARM,
and the value is different than what that this workaround suggests,
causing it to wrongly detect bad flags.
Change-Id: I02b0cc222ca7785c4b1739c3df3caa17cf7bc265
Reviewed-on: https://plan9port-review.googlesource.com/1094
Reviewed-by: Russ Cox <rsc@swtch.com>
|
|
Change-Id: I80331732ce955d5b025a3552d15c6d7494752bf6
Reviewed-on: https://plan9port-review.googlesource.com/1093
Reviewed-by: Russ Cox <rsc@swtch.com>
|
|
Credit to Roi Martin <jroi.martin@gmail.com> for noticing that
libdraw was being passed a negative string length and for finding the
sequence of keystrokes that make acme do it reproducibly.
Change-Id: If3f3d04a25c506175f740d3e887d5d83b5cd1bfe
Reviewed-on: https://plan9port-review.googlesource.com/1092
Reviewed-by: Russ Cox <rsc@swtch.com>
|
|
On OSX 10.10, when you open an application that depends on devdraw, the
title bar only shows the first letter of the application's name. The
patch sets a default title as soon as the window is created, which
fixes this issue.
On OSX 10.10, when you open an application that depends on devdraw, this
application is opened in top of other windows, however the menu bar is
not updated. The patch calls topwin() at the end of makewin() in
src/cmd/devdraw/cocoa-screen.m .
Change-Id: Ie036928b5574c8df20ad8b2b54047e2f7a22bb41
Reviewed-on: https://plan9port-review.googlesource.com/1091
Reviewed-by: Russ Cox <rsc@swtch.com>
|
|
Change-Id: Id3f1f8e16bbbaa99ead6d227c0b3dade9727ec61
Reviewed-on: https://plan9port-review.googlesource.com/1090
Reviewed-by: Russ Cox <rsc@swtch.com>
|
|
Change-Id: Ib80b19cf69a15860315b2d7a38baf3b05d693acc
|
|
These were *.C back in 2003, before the 9 script, to avoid conflicts
with the system utilities. A later change renamed them, but that
change seems to have been lost during the hg->git conversion
because I ran the conversion on a case-insensitive file system.
Change-Id: Id32c99cb9571ef0e185c3cc9e8c8d6d5b48ca195
|
|
Change-Id: I940a21d67b21b5dd139cb20b9fae9595506fc5ae
|
|
also update README.md for github
Change-Id: I7d578a902ffed7f6d69780721e29a1972b6f6992
|
|
Change-Id: I2e644aa2d693692f33d017c00367a734039532f1
|
|
Change-Id: Ifd9fda05e15c9e1e106ffd4e30e1dafe8423cdf4
|
|
- rewrite .gitignore to use git patterns
- mv hg(1) to git(1) and rewrite
- add lib/git/commit-msg.hook
- add skeleton codereview script
- update codereview(1)
Change-Id: I061cd8e4de77ebbd6037a7c5d1582cd1d986f62f
|
|
Change-Id: I3ed51b54252307f387f71955bbf547928bf26b5b
|
|
|
|
|
|
Thanks to Akshat Kumar for reporting this issue.
LGTM=seed, rsc
R=rsc, seed
https://codereview.appspot.com/173770043
|
|
fixed warnings:
src/cmd/fossil/disk.c:37:14: warning: use of GNU 'missing =' extension in designator [-Wgnu-designator]
src/cmd/fossil/disk.c:38:14: warning: use of GNU 'missing =' extension in designator [-Wgnu-designator]
src/cmd/fossil/disk.c:39:14: warning: use of GNU 'missing =' extension in designator [-Wgnu-designator]
src/cmd/fossil/disk.c:40:13: warning: use of GNU 'missing =' extension in designator [-Wgnu-designator]
src/cmd/fossil/disk.c:41:14: warning: use of GNU 'missing =' extension in designator [-Wgnu-designator]
src/libndb/ndbreorder.c:41:55: warning: for loop has empty body [-Wempty-body]
ignored warnings:
src/cmd/acid/dbg.y:393:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
src/cmd/bc.y:1327:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
src/cmd/bc.y:1327:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
src/cmd/grep/grep.y:420:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
src/cmd/grep/grep.y:420:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
src/cmd/hoc/hoc.y:692:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
src/cmd/hoc/hoc.y:692:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
src/cmd/lex/parser.y:886:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
src/cmd/rc/syn.y:303:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
src/cmd/units.y:1003:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
src/libregexp/regcomp.c:19:16: warning: variable 'reprog' is not needed and will not be emitted [-Wunneeded-internal-declaration]
LGTM=rsc
R=rsc
https://codereview.appspot.com/158250043
|
|
Found by nwf.
TBR=rsc
https://codereview.appspot.com/162860045
|
|
TBR=rsc
https://codereview.appspot.com/158240043
|