| Age | Commit message (Collapse) | Author | Files | Lines | |
|---|---|---|---|---|---|
| 2018-11-13 | plumb/basic: avoid wrap around in file:1:2 (#158) | Martin Kühl | 1 | -2/+2 | |
| Fixes #122, #140. As reported in #122, `file:1:1` moves to the end of the file, and `file:1:2` fails with “address out of range”. I’ll use file:2:3 as an example so we can tell the line and column number apart. What’s happening is this: plumb/basic matches `2:3` using twocolonaddr (from plumb/fileaddr), then sets addr to `2-#1+#3` (the 1 is constant and was introduced because column numbers are 1-based). Acme interprets this in three steps: 1. find the range (q0, q1) that contains line 2 2. create the range (q2, q2) where q2 = q0 - 1 3. create the range (q3, q3) where q3 = q2 + 3 The second step has a branch where if q0 == 0 and 1 > 0 (remember that 1 is constant and comes form plumb/basic), q0 is set to the end of the file. This makes addressing things at the end of the file easier. The problem then is that if we select line 1, which starts at the beginning of the file, q0 is always 0 and the branch in step 2) will always be used. `1:1` is interpreted as `1-#1+#1` which starts at 0, wraps around to the end of the file, then moves 1 character backwards and then forwards again, ending at the end of the file. `1:2` is interpretes as `1-#1+#2` which starts at 0, wraps around to the end od the file, then moves 1 character backwards and tries moving 2 characters forwards beyond the end of the file, resulting in the out of range error. In #140 @rsc proposed transforming `:X:Y` into `:X-#0+#Y-#1` instead since that avoids wrapping around by not moving backwards at first. This change modifies `plumb/basic` to do that. | |||||
| 2018-11-12 | plumb: allow @ in file names | Russ Cox | 1 | -9/+9 | |
| Helps Go module download cache, Upspin, maybe others. | |||||
| 2013-10-22 | acme: scroll a directory window when navigating if: | Rob Pike | 2 | -3/+12 | |
| - the cursor is on the last line - the navigation would put the cursor over the tag of the following text R=rsc CC=smckean83 https://codereview.appspot.com/15280045 | |||||
| 2011-08-31 | plumb: character offsets start at 1, not 0 | Russ Cox | 1 | -1/+1 | |
| x:10:1 is the beginning of line 10 R=rsc http://codereview.appspot.com/4960049 | |||||
| 2010-10-27 | plumb: column numbers in file address | Russ Cox | 2 | -0/+10 | |
| R=rsc http://codereview.appspot.com/2776042 | |||||
| 2009-05-17 | plumb: change inferno module path to /usr/inferno/module (Anthony Sorace) | Russ Cox | 1 | -2/+2 | |
| 2008-04-17 | plumbing: move email rule below file rules (Bengt Kleberg) | Russ Cox | 1 | -7/+7 | |
| 2007-04-03 | plumb all urls, not just images (TheWhiteTiger) | rsc | 1 | -11/+1 | |
| 2006-07-05 | allow _ - / in header file names | rsc | 1 | -4/+4 | |
| 2006-06-06 | use 9 page instead of page | rsc | 1 | -4/+4 | |
| 2005-01-11 | add $plan9 variable | rsc | 1 | -7/+6 | |
| 2004-08-22 | call wmail to send mail. | rsc | 1 | -1/+2 | |
| 2004-08-11 | plumbing foo.html now sends it to the editor -- | rsc | 1 | -5/+24 | |
| this is more in keeping with plan 9 behavior. plumbing file:foo.html adds the appropriate full path and sends it to the web browser. | |||||
| 2004-06-10 | use psv | rsc | 1 | -1/+1 | |
| 2004-06-09 | plumb urls and html to web browsers | rsc | 1 | -10/+9 | |
| 2004-05-14 | More little bug fixes | rsc | 1 | -1/+1 | |
| 2004-04-21 | small fixes | rsc | 1 | -3/+2 | |
| 2004-04-19 | push man pages through nobs. | rsc | 1 | -1/+1 | |
| 2004-03-05 | Various little fixes. | rsc | 1 | -0/+5 | |
| 2004-03-02 | Remove a debugging print, more cleanup. | rsc | 1 | -1/+1 | |
| 2004-03-02 | Little tweaks and documentation. | rsc | 1 | -4/+7 | |
| 2003-12-11 | Add support for user-level 9P servers/clients and various bug fixes to go ↵ | rsc | 1 | -14/+12 | |
| with them. | |||||
| 2003-12-04 | . | rsc | 1 | -2/+22 | |
| 2003-12-02 | B that knows about address syntax, | rsc | 1 | -3/+3 | |
| change plumber to use it. | |||||
| 2003-12-02 | More X11 snarf tweaks. | rsc | 1 | -3/+5 | |
| Will we ever finish? | |||||
| 2003-11-23 | add plumbing files. | rsc | 2 | -0/+108 | |