aboutsummaryrefslogtreecommitdiff
path: root/src/cmd/plumb/rules.c
AgeCommit message (Collapse)AuthorFilesLines
2019-09-19plumber: fix EOF detection on writes to rules file (#257)Fazlul Shahriar1-3/+3
Instead of checking Fcall.data==nil, check Fcall.count==0. The former check always fails after `gcc -O2` optimizations (gcc version 8.3.0). Also fix an out-of-bound read detected by valgrind: ``` ==31162== Invalid read of size 1 ==31162== at 0x11005E: morerules (rules.c:739) ==31162== by 0x110254: writerules (rules.c:775) ==31162== by 0x10D2FE: fsyswrite (fsys.c:848) ==31162== by 0x10C304: fsysproc (fsys.c:248) ==31162== by 0x112E8C: threadstart (thread.c:96) ==31162== by 0x4A682BF: ??? (in /usr/lib/libc-2.29.so) ==31162== Address 0x4ea984a is 0 bytes after a block of size 250 alloc'd ==31162== at 0x483AD7B: realloc (vg_replace_malloc.c:826) ==31162== by 0x1196F3: p9realloc (malloc.c:53) ==31162== by 0x10BDFD: erealloc (plumber.c:124) ==31162== by 0x10FCD9: concat (rules.c:642) ==31162== by 0x10FCD9: concat (rules.c:635) ==31162== by 0x110230: writerules (rules.c:773) ==31162== by 0x10D2FE: fsyswrite (fsys.c:848) ==31162== by 0x10C304: fsysproc (fsys.c:248) ==31162== by 0x112E8C: threadstart (thread.c:96) ==31162== by 0x4A682BF: ??? (in /usr/lib/libc-2.29.so) ``` Fixes #256
2012-05-15plumb: remove debugging printRuss Cox1-1/+0
R=rsc http://codereview.appspot.com/6210059
2005-09-09NetBSD-macppc ctype needs uchars.rsc1-3/+3
2005-01-11add $plan9 variablersc1-0/+5
2004-03-25Today's changes.rsc1-1/+1
More changes.
2004-03-05Amazingly picky bug fixes from Valgrind.rsc1-0/+1
2004-03-05Pipes cannot use SOCK_DGRAM. Back to SOCK_STREAM.rsc1-1/+1
Add debugging to fdwait. Rewrite getcallerpc on PowerMac to be correct.
2003-12-11Add support for user-level 9P servers/clients and various bug fixes to go ↵rsc1-2/+2
with them.
2003-11-23Plan 9 version, nothing tweaked yet.rsc1-0/+779