Age | Commit message (Collapse) | Author | Files | Lines |
|
See https://bitbucket.org/rsc/plan9port/issue/128/alt-button-sticks-in-acme-sometimes-after
R=rsc
https://codereview.appspot.com/11453043
|
|
R=rsc
https://codereview.appspot.com/10458043
|
|
There are two bugs in pdec() on INT_MIN:
* wrong output.
`n = 1-n' should be `n = -1-n' when n is INT_MIN.
* infinite loop.
gcc optimizes `if(n>=0)' into `if(true)' because `-INT_MIN' (signed integer overflow) is undefined behavior in C, and gcc assumes the negation of a negative number must be positive. The resulting binary keeps printing '-' forever given INT_MIN.
Try the simplified pdec.c below.
$ gcc pdec.c
$ ./a.out -2147483648
--214748364*
$ gcc pdec.c -O2
$ ./a.out -2147483648
<infinite loop>
$ gcc pdec.c -O2 -D__PATCH__
$ ./a.out -2147483648
-2147483648
=== pdec.c ===
#include <stdio.h>
#include <stdlib.h>
#include <limits.h>
#define io void
void pchr(io *f, int c)
{
putchar(c);
}
void pdec(io *f, int n)
{
if(n<0){
#ifndef __PATCH__
n=-n;
if(n>=0){
pchr(f, '-');
pdec(f, n);
return;
}
/* n is two's complement minimum integer */
n = 1-n;
#else
if(n!=INT_MIN){
pchr(f, '-');
pdec(f, -n);
return;
}
/* n is two's complement minimum integer */
n = -(INT_MIN+1);
#endif
pchr(f, '-');
pdec(f, n/10);
pchr(f, n%10+'1');
return;
}
if(n>9)
pdec(f, n/10);
pchr(f, n%10+'0');
}
int main(int argc, char **argv)
{
int n = atoi(argv[1]);
pdec(NULL, n);
putchar('\n');
}
R=rsc
CC=plan9port.codebot
https://codereview.appspot.com/7241055
|
|
R=rsc
https://codereview.appspot.com/7565045
|
|
For single-button mouse users.
R=rsc
https://codereview.appspot.com/7620043
|
|
R=rsc
https://codereview.appspot.com/7304064
|
|
Ubuntu Precise seems to have a buggy X server
that sometimes fails at XCopyArea. Let devdraw
do it itself.
This will slow down remote X a little bit,
but slow and correct is better than fast and broken.
R=rsc
https://codereview.appspot.com/7310069
|
|
R=rsc
CC=plan9port.codebot
https://codereview.appspot.com/7228044
|
|
R=rsc
https://codereview.appspot.com/7070070
|
|
R=rsc
https://codereview.appspot.com/7029054
|
|
R=rsc
https://codereview.appspot.com/7027044
|
|
|
|
R=rsc
CC=plan9port.codebot
https://codereview.appspot.com/6850108
|
|
R=rsc
http://codereview.appspot.com/6906057
|
|
R=rsc
https://codereview.appspot.com/6864051
|
|
R=rsc
https://codereview.appspot.com/6854130
|
|
R=rsc
http://codereview.appspot.com/6854094
|
|
R=rsc
http://codereview.appspot.com/6844083
|
|
R=rsc
http://codereview.appspot.com/6847105
|
|
R=rsc
http://codereview.appspot.com/6782115
|
|
R=rsc
http://codereview.appspot.com/6854093
|
|
R=rsc
http://codereview.appspot.com/6846104
|
|
R=rsc
CC=plan9port.codebot
http://codereview.appspot.com/6854092
|
|
Probably not the right fix, but gets us going.
R=rsc
http://codereview.appspot.com/6782113
|
|
R=rsc
http://codereview.appspot.com/6847104
|
|
Fixed at 100 right now, but the plan is to make it accurate
and then use it.
R=rsc
http://codereview.appspot.com/6856091
|
|
Also add some ignored files to .hgignore
R=rsc
http://codereview.appspot.com/6842089
|
|
R=rsc
http://codereview.appspot.com/6736060
|
|
R=rsc
CC=plan9port.codebot
http://codereview.appspot.com/6614056
|
|
R=rsc, 0intro
CC=plan9port.codebot
http://codereview.appspot.com/6739047
|
|
R=rsc
CC=plan9port.codebot
http://codereview.appspot.com/5495046
|
|
R=rsc
CC=plan9port.codebot
http://codereview.appspot.com/6690049
|
|
R=rsc
http://codereview.appspot.com/6744056
|
|
R=rsc
http://codereview.appspot.com/6744054
|
|
R=rsc
http://codereview.appspot.com/6744053
|
|
Enable with export devdrawretina=1 (everything will be smaller).
R=rsc
CC=plan9port.codebot
http://codereview.appspot.com/6592072
|
|
Fixes remote X11 use via XQuartz 2.7.4.
R=rsc
http://codereview.appspot.com/6624058
|
|
R=rsc, r
CC=plan9port.codebot
http://codereview.appspot.com/6586067
|
|
The code is adapted from Plan 9's import(4); this allows us to speak
that protocol. We don't currently support AAN (in the works) or
TLS/SSL.
Thanks to David for help with the man page, testing, and development.
R=0intro, rsc
CC=plan9port.codebot
http://codereview.appspot.com/6458100
|
|
If the mouse was in the tag of the old window,
it was most likely pointing at Del. If bringing up a
new window from below and not moving the mouse
somewhere else, adjust it so that it ends up pointing
at Del in the replacement window's tag too.
This makes it easy to Del a sequence of windows in
a column, from top to bottom.
http://www.youtube.com/watch?v=ET8w6RT6u5M
R=r
http://codereview.appspot.com/6558047
|
|
Don't want to require X11 during OS X build anymore.
R=rsc
http://codereview.appspot.com/6531045
|
|
R=r
http://codereview.appspot.com/6488137
|
|
Change is to handle FUSE_FORGET in main loop instead of separate thread for each as 10s of thousands can come in at once.
Fixes issue 104.
R=0intro, rsc
http://codereview.appspot.com/6498081
|
|
R=rsc
http://codereview.appspot.com/6503093
|
|
R=rsc
http://codereview.appspot.com/6445076
|
|
In the current code, the srv file is removed
just after the main thread exits, while the
srv thread is still running, which is not
the expected behavior.
We moved the srv creation just before the
procrfork, in order that the srv file will
not be removed until the srv thread exits.
R=rsc
http://codereview.appspot.com/6397047
|
|
This patch reverts the recent patch named "devdraw: fix for OS X 10.8", and fixes redrawing on OSX 10.8 differently, making scrolling under Acme 3 times faster.
R=rsc, mirtchovski
CC=plan9port.codebot
http://codereview.appspot.com/6452087
|
|
In MacOS 10.8, the NSBitmapImageRep class appears to cache the specified
image data at the time of construction. As a result updates to the
backing memimage object do not get pushed to the screen in flushimg.
This patch creates the NSBitmapImageRep object over again for each
flushimg which would appear to fix the problem.
R=rsc
CC=plan9port.codebot
http://codereview.appspot.com/6443063
|
|
R=rsc, rsc
http://codereview.appspot.com/6405057
|
|
R=rsc
http://codereview.appspot.com/6402044
|