aboutsummaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)AuthorFilesLines
2014-12-029pfuse: Disable glibc workaround for O_LARGEFILE on ARMMerlijn Wajer1-1/+4
9pfuse fails on ARM when O_LARGEFILE is supported. glibc does define O_LARGEFILE properly on ARM, and the value is different than what that this workaround suggests, causing it to wrongly detect bad flags. Change-Id: I02b0cc222ca7785c4b1739c3df3caa17cf7bc265 Reviewed-on: https://plan9port-review.googlesource.com/1094 Reviewed-by: Russ Cox <rsc@swtch.com>
2014-12-02libdraw, libframe, acme: fix, guard against inverted range in textsetselectRuss Cox3-3/+15
Credit to Roi Martin <jroi.martin@gmail.com> for noticing that libdraw was being passed a negative string length and for finding the sequence of keystrokes that make acme do it reproducibly. Change-Id: If3f3d04a25c506175f740d3e887d5d83b5cd1bfe Reviewed-on: https://plan9port-review.googlesource.com/1092 Reviewed-by: Russ Cox <rsc@swtch.com>
2014-12-02devdraw: fix title and "open in top" on OS XRoi Martin1-1/+4
On OSX 10.10, when you open an application that depends on devdraw, the title bar only shows the first letter of the application's name. The patch sets a default title as soon as the window is created, which fixes this issue. On OSX 10.10, when you open an application that depends on devdraw, this application is opened in top of other windows, however the menu bar is not updated. The patch calls topwin() at the end of makewin() in src/cmd/devdraw/cocoa-screen.m . Change-Id: Ie036928b5574c8df20ad8b2b54047e2f7a22bb41 Reviewed-on: https://plan9port-review.googlesource.com/1091 Reviewed-by: Russ Cox <rsc@swtch.com>
2014-11-17cmd: rename *.C to *.cRuss Cox4-0/+0
These were *.C back in 2003, before the 9 script, to avoid conflicts with the system utilities. A later change renamed them, but that change seems to have been lost during the hg->git conversion because I ran the conversion on a case-insensitive file system. Change-Id: Id32c99cb9571ef0e185c3cc9e8c8d6d5b48ca195
2014-10-21fix clang 3.4 warnings and ignore uninteresting onesDavid du Colombier2-6/+6
fixed warnings: src/cmd/fossil/disk.c:37:14: warning: use of GNU 'missing =' extension in designator [-Wgnu-designator] src/cmd/fossil/disk.c:38:14: warning: use of GNU 'missing =' extension in designator [-Wgnu-designator] src/cmd/fossil/disk.c:39:14: warning: use of GNU 'missing =' extension in designator [-Wgnu-designator] src/cmd/fossil/disk.c:40:13: warning: use of GNU 'missing =' extension in designator [-Wgnu-designator] src/cmd/fossil/disk.c:41:14: warning: use of GNU 'missing =' extension in designator [-Wgnu-designator] src/libndb/ndbreorder.c:41:55: warning: for loop has empty body [-Wempty-body] ignored warnings: src/cmd/acid/dbg.y:393:9: warning: array index -1 is before the beginning of the array [-Warray-bounds] src/cmd/bc.y:1327:9: warning: array index -1 is before the beginning of the array [-Warray-bounds] src/cmd/bc.y:1327:9: warning: array index -1 is before the beginning of the array [-Warray-bounds] src/cmd/grep/grep.y:420:9: warning: array index -1 is before the beginning of the array [-Warray-bounds] src/cmd/grep/grep.y:420:9: warning: array index -1 is before the beginning of the array [-Warray-bounds] src/cmd/hoc/hoc.y:692:9: warning: array index -1 is before the beginning of the array [-Warray-bounds] src/cmd/hoc/hoc.y:692:9: warning: array index -1 is before the beginning of the array [-Warray-bounds] src/cmd/lex/parser.y:886:9: warning: array index -1 is before the beginning of the array [-Warray-bounds] src/cmd/rc/syn.y:303:9: warning: array index -1 is before the beginning of the array [-Warray-bounds] src/cmd/units.y:1003:9: warning: array index -1 is before the beginning of the array [-Warray-bounds] src/libregexp/regcomp.c:19:16: warning: variable 'reprog' is not needed and will not be emitted [-Wunneeded-internal-declaration] LGTM=rsc R=rsc https://codereview.appspot.com/158250043
2014-10-21venti/copy: fix bug writing directories that zero truncateRuss Cox1-1/+1
Found by nwf. TBR=rsc https://codereview.appspot.com/162860045
2014-10-20col: import from plan 9, by popular demandRuss Cox1-0/+295
TBR=rsc https://codereview.appspot.com/158240043
2014-10-209l: link with -lresolv on LinuxDavid du Colombier1-2/+0
LGTM=rsc R=rsc https://codereview.appspot.com/136520044
2014-08-06vbackup: fix compilation on NetBSD (thanks Álvaro Jurado)David du Colombier1-0/+4
On NetBSD 5.0 and upper, mount() require data_len as a fifth argument. LGTM=rsc R=rsc CC=elbingmiss https://codereview.appspot.com/111600043
2014-07-09mc: use $termprog to identify 9termRuss Cox1-1/+1
TBR=rsc https://codereview.appspot.com/112890043
2014-06-05upas: fix nil pointer dereferenceDavid du Colombier1-2/+2
R=rsc https://codereview.appspot.com/92650043
2014-06-03upas/common: rename aux to auxxRuss Cox2-1/+1
TBR=rsc https://codereview.appspot.com/107760043
2014-06-03acme: fix bufread crash due to typing-point scrollingRuss Cox1-0/+4
Acme tracks the most recent typing insertion point and the home and end keys stop there on their way up to the top or down to the bottom of the file. That point should be iq1, and it should be adjusted properly so that it's always between 0 and t->file->b.nc inclusive. (This is all code from an external contributor, years old at this point but new since Plan 9.) Somehow, sometimes iq1 ends up a little beyond b.nc, and when passed to textbacknl it crashes acme in bufread. I can't see how that can happen but if it does, avoid the crash. It's tempting to pull the insertion point code out entirely but this is a little less invasive and should fix things for now. TBR=rsc https://codereview.appspot.com/107730043
2014-06-03acme: increase timer resolution to 10msRuss Cox1-1/+1
We ran for a long time with 10ms kernel resolution, so 10ms user space resolution here should be fine. Some systems actually provide 1ms sleeps, which makes this polling use a bit more cpu than we'd like. Since the timers are for user-visible things, 10ms should still be far from noticeable. Reduces acme's cpu usage on Macs when plumber is missing (and plumbproc is sleeping waiting for it to appear). LGTM=aram, r R=r, aram https://codereview.appspot.com/99570043
2014-05-19undo CL 69070045 / 8539a916d98aRuss Cox1-4/+0
This breaks ^C in win windows, as expected. People use ^C, win expects and handles ^C, so I don't think we can just take it away. I've noticed that it is broken but assumed my ssh was screwed up. If you want to make WindowsKey+C,X,V do the operations, by analogy with command+C,X,V on Mac, that's fine with me. ««« original CL description acme: copy/cut/paste with ctl+c,x,v LGTM=rsc R=rsc CC=plan9port.codebot https://codereview.appspot.com/69070045 »»» TBR=rsc CC=burns.ethan, r https://codereview.appspot.com/96410045
2014-05-15upas: fix warningsDavid du Colombier2-3/+3
smtp.c:232: warning: comparison with string literal results in unspecified behavior smtp.c:244: warning: comparison with string literal results in unspecified behavior marshal.c:1179: warning: variable ‘err’ set but not used LGTM=rsc R=rsc https://codereview.appspot.com/93290043
2014-05-15libndb: add AUTOLIB(resolv)David du Colombier1-0/+2
LGTM=rsc R=rsc https://codereview.appspot.com/97370043
2014-05-05acme: fix two flush bugs in new log fileRuss Cox1-2/+3
TBR=rsc https://codereview.appspot.com/95010048
2014-04-30acme: add log file in acme root directoryRuss Cox11-6/+236
Reading /mnt/acme/log reports a log of window create, put, and delete events, as they happen. It blocks until the next event is available. Example log output: 8 new /Users/rsc/foo.go 8 put /Users/rsc/foo.go 8 del /Users/rsc/foo.go This lets acme-aware programs react to file writes, for example compiling code, running a test, or updating an import block. TBR=r R=r https://codereview.appspot.com/89560044
2014-04-19acme: add comment for aligned writesRuss Cox1-0/+5
TBR=r https://codereview.appspot.com/89510044
2014-04-19acme: use buffered i/o to write fileRuss Cox1-1/+16
Bakul Shah has observed corrupted files being written when acme writes over osxfuse to sshfs to a remote file system. In one example we examined, acme is writing an 0xf03-byte file in two system calls, first an 0x806-byte write and then a 0x6fd-byte write. (0x806 is BUFSIZE/sizeof(Rune); this file has no multibyte UTF-8.) What actually ends up happening is that an 0x806-byte file is written: 0x000-0x6fd contains what should be 0x806-0xf03 0x6fd-0x7fa contains zeros 0x7fa-0x806 contains what should be 0x7fa-0x806 (correct!) The theory is that fuse or sshfs or perhaps the remote file server is mishandling the unaligned writes. acme does not seem to be at fault. Using bio here will make the writes align to 8K boundaries, avoiding the bugs in whatever underlying piece is broken. TBR=r https://codereview.appspot.com/89550043
2014-04-18acme: fix Get of dir in nameless window (thanks Colton Lewis)Russ Cox1-1/+1
TBR=r https://codereview.appspot.com/89390043
2014-03-13acme: copy/cut/paste with ctl+c,x,vEthan Burns1-0/+4
LGTM=rsc R=rsc CC=plan9port.codebot https://codereview.appspot.com/69070045
2014-03-13acme, sam: handle >1GB files correctlyRuss Cox4-4/+10
TBR=rsc https://codereview.appspot.com/74060043
2014-03-03fix gcc 4.8 warningsDavid du Colombier6-15/+5
LGTM=rsc R=rsc https://codereview.appspot.com/33240044
2014-03-03fossil: fix p9p changes on viewDavid du Colombier1-26/+28
LGTM=rsc R=rsc https://codereview.appspot.com/31130043
2014-02-27all: DragonFly port.Shenghou Ma11-13/+348
Fix compilation problems, libdraw still doesn't work right yet. LGTM=rsc R=rsc https://codereview.appspot.com/67820046
2014-01-22devdraw: clear altdown on focus out (thanks Ethan Burns)Russ Cox1-0/+1
TBR=rsc https://codereview.appspot.com/53820044
2013-10-23fossil: fix remaining warningsDavid du Colombier5-13/+13
R=rsc https://codereview.appspot.com/15100044
2013-10-22acme: scroll a directory window when navigating if:Rob Pike1-1/+17
- the cursor is on the last line - the navigation would put the cursor over the tag of the following text R=rsc CC=smckean83 https://codereview.appspot.com/15280045
2013-09-26xd: fix build by declaring swizz8David du Colombier1-1/+1
R=rsc https://codereview.appspot.com/13982043
2013-09-26fossil: cleanup mkfileDavid du Colombier1-62/+1
R=rsc https://codereview.appspot.com/13988043
2013-09-26fossil: import conf.rcDavid du Colombier1-0/+68
R=rsc https://codereview.appspot.com/13983043
2013-09-26fossil: cast Qid.vers, Dir.mode and Qid.mtime to u32int (thanks Tim Kack)David du Colombier1-4/+4
R=rsc https://codereview.appspot.com/13981043
2013-09-26fossil: fix various warningsDavid du Colombier5-95/+0
R=rsc https://codereview.appspot.com/13980043
2013-09-26fossil: required p9p changesDavid du Colombier15-67/+156
R=rsc https://codereview.appspot.com/13352057
2013-09-23fossil: move from liboventi to libthread and libventiDavid du Colombier38-1424/+1360
R=rsc https://codereview.appspot.com/13504049
2013-09-23fossil: import from plan 9David du Colombier48-0/+20604
R=rsc https://codereview.appspot.com/7988047
2013-09-06acme: execute commands with / using shellMarius Eriksen1-1/+1
This allows commands in bin subdirectories. R=rsc CC=plan9port.codebot https://codereview.appspot.com/13254044
2013-09-06acme Mail: add Search commandAkshat Kumar2-1/+63
Introduces the Search command for mailboxes. Arguments passed are treated as one space- separated string, passed on to mailfs' IMAP search interface. R=rsc, david.ducolombier CC=plan9port.codebot https://codereview.appspot.com/13238044
2013-09-06mailfs: allow spaces in box nameAkshat Kumar1-1/+16
Mail services (such as Google Mail) will often have directories with names that contain spaces. Acme does not support spaces in window names. So, replace spaces in mail directory names with the Unicode character for visible space. The code is a bit of an over-approximation and generally non-optimal. R=rsc, david.ducolombier, 0intro CC=plan9port.codebot https://codereview.appspot.com/13010048
2013-09-06mailfs: support for UTF-8 searchesAkshat Kumar1-10/+45
UTF-8 searches with the SEARCH command must be conducted in two steps: the first sends the SEARCH command with the length of the UTF-8 encoded string and the second sends the literal search term. The searches need to not be quoted. R=rsc, david.ducolombier, rsc, 0intro CC=plan9port.codebot https://codereview.appspot.com/13244043
2013-08-06devdraw: set window name to argv[0]Russ Cox1-0/+120
R=rsc CC=r https://codereview.appspot.com/12577043
2013-08-069term: set TERM=dumb instead of TERM=9termRuss Cox4-1/+13
Everyone seems to assume that TERM != dumb implies ANSI escape codes are okay. In fact, many people assume that unconditionally, but it is easier to argue back about TERM=dumb than TERM=9term. This applies to acme win too, because they share the code. Set termprog=9term or termprog=win for clients who need to know. R=rsc CC=r https://codereview.appspot.com/12532043
2013-07-31acme: allow :6 in 5-line fileRuss Cox1-0/+2
R=rsc https://codereview.appspot.com/12162043
2013-07-17cmd/devdraw: clear keyboard state on lost focus.Roger Peppe1-0/+6
See https://bitbucket.org/rsc/plan9port/issue/128/alt-button-sticks-in-acme-sometimes-after R=rsc https://codereview.appspot.com/11453043
2013-07-02libregexp: update from Plan 9David du Colombier5-24/+25
R=rsc https://codereview.appspot.com/10690044
2013-06-21devdraw: fix x11 inputRuss Cox1-1/+1
R=rsc https://codereview.appspot.com/10458043
2013-03-19rc: avoid undefined CXi Wang1-4/+4
There are two bugs in pdec() on INT_MIN: * wrong output. `n = 1-n' should be `n = -1-n' when n is INT_MIN. * infinite loop. gcc optimizes `if(n>=0)' into `if(true)' because `-INT_MIN' (signed integer overflow) is undefined behavior in C, and gcc assumes the negation of a negative number must be positive. The resulting binary keeps printing '-' forever given INT_MIN. Try the simplified pdec.c below. $ gcc pdec.c $ ./a.out -2147483648 --214748364* $ gcc pdec.c -O2 $ ./a.out -2147483648 <infinite loop> $ gcc pdec.c -O2 -D__PATCH__ $ ./a.out -2147483648 -2147483648 === pdec.c === #include <stdio.h> #include <stdlib.h> #include <limits.h> #define io void void pchr(io *f, int c) { putchar(c); } void pdec(io *f, int n) { if(n<0){ #ifndef __PATCH__ n=-n; if(n>=0){ pchr(f, '-'); pdec(f, n); return; } /* n is two's complement minimum integer */ n = 1-n; #else if(n!=INT_MIN){ pchr(f, '-'); pdec(f, -n); return; } /* n is two's complement minimum integer */ n = -(INT_MIN+1); #endif pchr(f, '-'); pdec(f, n/10); pchr(f, n%10+'1'); return; } if(n>9) pdec(f, n/10); pchr(f, n%10+'0'); } int main(int argc, char **argv) { int n = atoi(argv[1]); pdec(NULL, n); putchar('\n'); } R=rsc CC=plan9port.codebot https://codereview.appspot.com/7241055
2013-03-19libsec: avoid undefined CXi Wang1-2/+1
gcc compiles `p + length < p' into 'length < 0' since pointer overflow is undefined behavior in C. This breaks the check against a large `length'. Use `length > pend - p' instead. There's no need to check `length < 0' since `length' is from length_decode() and should be non-negative. === Try the simplified code. void bar(void); void foo(unsigned char *p, int length) { if (p + length < p) bar(); } $ gcc -S -o - t.c -O2 ... foo: .LFB0: .cfi_startproc testl %esi, %esi js .L4 rep ret .L4: jmp bar .cfi_endproc Clearly `p' is not used at all. R=rsc CC=plan9port.codebot https://codereview.appspot.com/7231069
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-10 01:06:10 +0000