From 9689b580bdb168b87a20a5e466864337d591acfa Mon Sep 17 00:00:00 2001 From: rsc Date: Wed, 27 Jul 2005 20:25:34 +0000 Subject: Try to avoid races in underlying C library during threadexitsall. --- src/libthread/BSD.c | 14 ++++++++++++++ src/libthread/Linux.c | 14 ++++++++++++++ 2 files changed, 28 insertions(+) (limited to 'src/libthread') diff --git a/src/libthread/BSD.c b/src/libthread/BSD.c index 0bc19057..8090ea59 100644 --- a/src/libthread/BSD.c +++ b/src/libthread/BSD.c @@ -285,6 +285,20 @@ threadexitsall(char *msg) int i, npid, mypid; Proc *p; + /* + * Only one guy, ever, gets to run this. + * If two guys do it, inevitably they end up + * tripping over each other in the underlying + * C library exit() implementation, which is + * trying to run the atexit handlers and apparently + * not thread safe. This has been observed on + * both Linux and OpenBSD. Sigh. + */ + { + static Lock onelock; + lock(&onelock); + } + if(msg == nil) msg = ""; mypid = getpid(); diff --git a/src/libthread/Linux.c b/src/libthread/Linux.c index f741a03d..14698856 100644 --- a/src/libthread/Linux.c +++ b/src/libthread/Linux.c @@ -311,6 +311,20 @@ threadexitsall(char *msg) int i, npid, mypid; Proc *p; + /* + * Only one guy, ever, gets to run this. + * If two guys do it, inevitably they end up + * tripping over each other in the underlying + * C library exit() implementation, which is + * trying to run the atexit handlers and apparently + * not thread safe. This has been observed on + * both Linux and OpenBSD. Sigh. + */ + { + static Lock onelock; + lock(&onelock); + } + if(msg == nil) msg = ""; mypid = getpid(); -- cgit v1.2.3