From 73392c2c7cc2e74759480a37e345366dfa265926 Mon Sep 17 00:00:00 2001 From: David du Colombier <0intro@gmail.com> Date: Mon, 12 Dec 2011 16:44:50 -0500 Subject: libventi: fix segfault in vtreadpacket when not connected This problem happens especially in fossil/view when vtread can be called even if not connected to venti. The old libventi handle this case properly in the function vtRPC, which is called by vtReadPacket (client.c). R=rsc CC=plan9port.codebot http://codereview.appspot.com/5484044 --- src/libventi/client.c | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'src') diff --git a/src/libventi/client.c b/src/libventi/client.c index 9f200f48..f76fd343 100644 --- a/src/libventi/client.c +++ b/src/libventi/client.c @@ -65,6 +65,11 @@ vtreadpacket(VtConn *z, uchar score[VtScoreSize], uint type, int n) if(memcmp(score, vtzeroscore, VtScoreSize) == 0) return packetalloc(); + if(z == nil){ + werrstr("not connected"); + return nil; + } + if(z->version[1] == '2' && n >= (1<<16)) { werrstr("read count too large for protocol"); return nil; -- cgit v1.2.3