diff options
| author | David du Colombier <0intro@gmail.com> | 2014-05-15 06:28:54 +0200 |
|---|---|---|
| committer | David du Colombier <0intro@gmail.com> | 2014-05-15 06:28:54 +0200 |
| commit | bae34df843174dd2dfcbb3e584ea8f963f0c1d32 (patch) | |
| tree | 903abd62592e1010c8a13b54f3e8a58692fef259 /src/cmd/upas | |
| parent | 954e03ccfe21a06da9d581c04e92bf87feec192e (diff) | |
| download | plan9port-bae34df843174dd2dfcbb3e584ea8f963f0c1d32.tar.gz plan9port-bae34df843174dd2dfcbb3e584ea8f963f0c1d32.tar.bz2 plan9port-bae34df843174dd2dfcbb3e584ea8f963f0c1d32.zip | |
upas: fix warnings
smtp.c:232: warning: comparison with string literal results in unspecified behavior
smtp.c:244: warning: comparison with string literal results in unspecified behavior
marshal.c:1179: warning: variable ‘err’ set but not used
LGTM=rsc
R=rsc
https://codereview.appspot.com/93290043
Diffstat (limited to 'src/cmd/upas')
| -rw-r--r-- | src/cmd/upas/marshal/marshal.c | 2 | ||||
| -rw-r--r-- | src/cmd/upas/smtp/smtp.c | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/src/cmd/upas/marshal/marshal.c b/src/cmd/upas/marshal/marshal.c index 7cef1828..8ebd3957 100644 --- a/src/cmd/upas/marshal/marshal.c +++ b/src/cmd/upas/marshal/marshal.c @@ -1183,7 +1183,7 @@ waitforsubprocs(void) err = w->msg; if(pid >= 0 && (w=procwait(pid)) && w->msg[0]) err = w->msg; - return nil; + return err; } int diff --git a/src/cmd/upas/smtp/smtp.c b/src/cmd/upas/smtp/smtp.c index 893f5789..62ef865e 100644 --- a/src/cmd/upas/smtp/smtp.c +++ b/src/cmd/upas/smtp/smtp.c @@ -229,7 +229,7 @@ threadmain(int argc, char **argv) for(i = 0; i < argc; i++){ if((trv = rcptto(argv[i])) != 0){ /* remember worst error */ - if(rv != Giveup) + if(strcmp(rv, Giveup) != 0) rv = trv; errs[rcvrs] = strdup(s_to_c(reply)); removenewline(errs[rcvrs]); @@ -241,7 +241,7 @@ threadmain(int argc, char **argv) } /* if no ok rcvrs or worst error is retry, give up */ - if(ok == 0 || rv == Retry) + if(ok == 0 || strcmp(rv, Retry) == 0) goto error; if(ping){ |